[Freeipa-devel] [PATCH] 0267-dnsrecord-mod-ui

[Endi Sukma Dewata]

On 7/13/2011 4:03 PM, Adam Young wrote:
>>>> 3. I cannot try this due to issue #2, but in CLI when the last data
>>>> is removed using -mod the record itself will be deleted. The record
>>>> has to be re-added before it can be modified again. A user might
>>>> encounter this issue if he removes all existing data, click Update,
>>>> then add new data without leaving the details page. The patch
>>>> doesn't seem to handle this.
>>>
>>> It works that way. Right now, there is an issue where the mod comand
>>> comes back, we use it to populate the page, but updates won't work
>>> because there is nothing there. We'll need code specific to the
>>> dnsrecord-mod command to handle this. Not done yet

As discussed over IRC, this will be fixed in a separate ticket.

>>>> 4. The interface might be a little confusing. If a DNS record
>>>> contains multiple data, the search page will show them as separate
>>>> entries. When a user opens one of the entries he would expect to
>>>> edit only that particular data. However, the details page now shows
>>>> all data under that DNS record name.
>>>>
>>>> One solution is to drop the data from the search page. Another
>>>> solution is to change the details page to show only one data.
>>>
>>> I like having the individual records on the search page, and I think
>>> it is most intuitive, but it does make the UI hard.

Separate ticket.

>>>> 7. DNS records that are not hostnames will be linked to hosts if
>>>> there happens to be hosts with matching names. The link probably
>>>> should be limited to certain record types. Same issue from host to
>>>> DNS record.
>>>
>>> Going to leave this as is. If there is truly confusion around this,
>>> we can make the logic more complex, but I suspect that the current
>>> implementation is what people expect.

We'll wait for feedback before filing any ticket.

19. The IPA.dnsrecord_get_delete_values() is getting the column values 
from the displayed texts. While this is fine for this particular case, 
sometimes the value is formatted so the displayed text may not match the 
value stored on the server. We'll address that when that happens.

ACK and pushed to master.

-- 
Endi S. Dewata