[Freeipa-devel] [PATCH] 096 Fix ipa-dns-install incorrect warning

[Martin Kosek]

On Mon, 2011-07-18 at 13:49 +0200, Jan Cholasta wrote:
> On 18.7.2011 12:56, Martin Kosek wrote:
> > ipa-dns-install incorrectly warns about non-local IP addresses
> > when installing without --ip-address parameter.
> >
> > https://fedorahosted.org/freeipa/ticket/1486
> >
> 
> IMO the warning message should be removed from parse_ip_address 
> altogether, as the local IP address check is done in 
> CheckedIPAddress.__init__. This makes both parse_ip_address and 
> verify_ip_address unnecessary, because all they do is call 
> CheckedIPAddress, so calls to them should be replaced with calls to 
> CheckedIPAddress directly.
> 
> I've made a patch that does all of this and also removes some redundant 
> IP address checks from ipa-server-install, see attachment.
> 
> Honza
> 

I agree. This will clean up the mess around CheckedIPAddress.

Pushed to master.

Martin