[Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

[Adam Young]

On 07/20/2011 10:22 PM, Endi Sukma Dewata wrote:
> On 7/20/2011 7:08 PM, Endi Sukma Dewata wrote:
>>
>
> This is based on patch 270-2:
>
> 19. Updating HBAC and sudo rules doesn't work, the fields always reset 
> to the original values. No undo buttons appear.
Fixed
>
> 20. The Get & View buttons in host details page generate an error. 
> Create a host called test.example.com, then create a new certificate 
> with this CSR:
>
> MIIBezCB5QIBADA8MR8wHQYDVQQKDBZJRE0uTEFCLkJPUy5SRURIQVQuQ09NMRkw
> FwYDVQQDDBB0ZXN0LmV4YW1wbGUuY29tMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCB
> iQKBgQDYOFeE6Y16kQ1gSvlnUU/LOaQlbsYnkfOCZ9UOaeg1RbKXFIJYB0s1DAa8
> biI8gb6ZpzDjcAtNZHchOBtXnl0BBPOhkF6nD444SImz6eUBCmcCNeF4lgmNTxUS
> W2AkWl4vgXGwWSlxSrBIcylIqsIMMdYg71mUeTyuJLit8bGQdwIDAQABoAAwDQYJ
> KoZIhvcNAQEFBQADgYEAKb3/9gkJuOf3wRGe2n+FAfqBzStq8r5SLyVa5JyOxBhJ
> nKGrTcv95X+2ch8RPqvOg8lgn12Js/Rm3ipb0MlCkBYeq8b0RQv4N0sG2dqJG8a1
> yxhxxIjovisey6F09cOyZljAhpJ6Qeqd7GHr7HFCPTDWrYDIb8QpiRrgNFvBtIQ=

Not yet fixed.  I need to generate a new CSR, as my REALM does not match 
the one used above.

>
> 21. The host's and service's managed_by facet contains duplicate 'host 
> name' columns.
fixe
>
> 22. The DNS zone adder dialog is missing the buttons.

Fixed.  I did this by changing the layout on the adder.
>
> 23. The field_name attribute is no longer needed in service.js:129.
gone
>
> 24. Commented code in aci_tests.js:45,64 can be removed.
gone
>
> 25. Commented code in details_tests.js:69 can be removed.
gone
>
> 26. The assignment in widget_tests.js:44 should be spec = null.
fixed
>
> 27. Commented code in widget_tests.js:64,67,70,184 can be removed.
gone
>
> 28. The unused parameter in widget_tests.js:82 can be removed.
gone
>
> 29. The statement in user.js:175 is redundant:
>
>   var entity = IPA.get_entity(that.entity.name);
>
gone
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0270-7-removing-setters-setup-and-init.patch
Type: text/x-patch
Size: 199910 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110721/a4283bd4/attachment.bin>