[Freeipa-devel] [PATCH] 836 Don't check for leading/trailing spaces on cert

[Martin Kosek]

On Fri, 2011-07-22 at 10:25 -0400, Rob Crittenden wrote:
> Martin Kosek wrote:
> > On Thu, 2011-07-21 at 16:50 -0400, Rob Crittenden wrote:
> >> Rob Crittenden wrote:
> >>> Don't check for leading/trailing spaces when loading an entitlement cert
> >>>
> >>> ticket https://fedorahosted.org/freeipa/ticket/1505
> >>
> >> With API.txt update, doesn't affect wire protocol.
> >
> > NACK.
> >
> > 1) I think we should disable extra whitespace rule for the entire File
> > parameter. This parameter is most often filled with content of the
> > referred file (as with entitle-import or cert-request) and we don't want
> > to check whitespace inside of files. You can check that cert-request
> > will also fail if there is a leading/trailing whitespace in the referred
> > CSR.
> >
> > 2) There are changes in freeipa.spec.in in cyrus-sasl-gssapi. I think
> > this should be in a separate patch, I don't see the relevance.
> >
> > Martin
> >
> 
> Fixed.

ACK. Pushed to master.

Martin