[Freeipa-devel] [PATCH] 103 Fix automountkey-mod

[Dmitri Pal]

On 07/27/2011 12:00 PM, Martin Kosek wrote:
> On Wed, 2011-07-27 at 10:41 -0400, Rob Crittenden wrote:
>> Martin Kosek wrote:
>>> Fix automountkey-mod so that automountkey attribute is correctly
>>> updated. Add this test case to the unit tests.
>>>
>>> https://fedorahosted.org/freeipa/ticket/1528
>> It fixes the problem but I've found another: --key isn't required so if 
>> you don't pass it in then a backtrace will occur:
>>
>> Traceback (most recent call last):
>>    File "/home/rcrit/redhat/freeipa-master/ipaserver/rpcserver.py", line 
>> 220, in wsgi_execute
>>      result = self.Command[name](*args, **options)
>>    File "/home/rcrit/redhat/freeipa-master/ipalib/frontend.py", line 
>> 425, in __call__
>>      ret = self.run(*args, **options)
>>    File "/home/rcrit/redhat/freeipa-master/ipalib/frontend.py", line 
>> 731, in run
>>      return self.execute(*args, **options)
>>    File "/home/rcrit/redhat/freeipa-master/ipalib/plugins/automount.py", 
>> line 873, in execute
>>      keys += (self.obj.get_pk(options['automountkey'],
>> KeyError: 'automountkey'
>>
>> Also, automountinformation is already required. This may be a leftover 
>> from when we used it in description, this can probably be lifted too.
>>
>> rob
> Good catch. I fixed this bug too and I also made --newinfo optional so
> that automountkey may be just renamed without changing its info
> attribute.
>
> I didn't bump up API VERSION as these are either compatible changes or
> they caused server internal error.
>
> Martin

Should the ticket be moved into 2.1 July sprint then?

>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110727/0cd5a01d/attachment.htm>