[Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

[Adam Young]

On 07/28/2011 01:26 AM, Endi Sukma Dewata wrote:
> On 7/27/2011 8:14 PM, Adam Young wrote:
>>>>> 59. The initialization area in IPA.association_adder_dialog
>>>>> (association.js:212) should be marked with a comment.
>>>> Done
>>>
>>> The default_columns() invocation should be moved into the
>>> initialization area because this is not a precondition checking like
>>> in #57. The default_columns() function itself should be moved outside
>>> of the initialization area because the area should not contain
>>> function definition, only invocations.
>>
>> The columns need to be defined before the table setup in the base class,
>> which is why it is done at the top of the function, prior to calling the
>> baseclass. Going to leave this as is.
>
> Please add a note near default_columns() definition saying that the 
> columns map in IPA.adder_dialog should be removed and the add_column() 
> should be modified to add the column directly into the available_table 
> and selected_table. This way IPA.association_adder_dialog can call 
> create_column() from the initialization area, no need to modify the 
> parameters.
Done
>
>>>>> 62. Since the code in #60 and #61 is moved to initialization area, 
>>>>> the
>>>>> spec.link can be reverted back to that.link.
>>>>
>>>> Removed link. I don't see where it is used. Tested without it and
>>>> everything seems to work fine.
>>>
>>> The link flag is used to create a link from the association facet to
>>> the target entity (see association.js:723 and widget.js:1152). The
>>> original code sets the flag to true by default.
>>>
>>> To test, create a netgroup and enroll a user. The user should be 
>>> linked.
>> Still works. True is deduced by default. I think at this point you would
>> have to send link = false to disable, and that probably makes no sense.
>> Going to leave this as is.

OK, back to being spec.link, as it has to be set prior to the call to 
the base class.  Put a comment in to this effect.

>
> It still doesn't work for me. Make sure you are looking at "Members 
> Users" facet in Netgroup, not the other way around. The reverse link 
> from user to netgroup works because the flag is explicitly set in 
> user.js. In netgroup.js and other files the link is not set, so it 
> will use the default. All variables are undefined by default and 
> considered false. The original code reversed the default.
>
> 79. Regression: The Unprovision button in host details page doesn't 
> work. To test, enroll a host with this command:
>
> ipa-getkeytab -s localhost -p host/test.example.com -k test.keytab

Fixed
>
> Then open the host details page. Click the "Delete Key, Unprovision" 
> button, click Unprovision again, it will fail. The that.entity_name in 
> host.js:381 should be changed to that.entity.name.
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0280-1-additional-fixes-for-removal-of-init-and-setup.patch
Type: text/x-patch
Size: 2894 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110728/868b88ea/attachment.bin>