[Freeipa-devel] [PATCH] 0008 Modify /etc/sysconfig/network on a client when IPA manages hostname

[Martin Kosek]

On Fri, 2011-07-29 at 12:46 +0300, Alexander Bokovoy wrote:
> On 29.07.2011 12:21, Alexander Bokovoy wrote:
> > On 29.07.2011 12:01, Martin Kosek wrote:
> >> On Fri, 2011-07-29 at 11:42 +0300, Alexander Bokovoy wrote:
> >>> https://fedorahosted.org/freeipa/ticket/1368
> >>>
> >>> also replaces a tab by spaces in one else statement (cosmetic).
> >>
> >> This works fine. But I have few suggestion for improvement:
> >>
> >> 1) Shouldn't we also run `hostname NEW_HOSTNAME` so that the new
> >> hostname is properly set on the system?
> > Makes sense.
> > 
> >> 2) I would enhance our man pages/help and state that we are changing the
> >> system hostname. Current --hostname option is confusing:
> >>
> >>        --hostname
> >>               The hostname of this server (FQDN).  By  default  of  nodename  from
> >>               uname(2) is used.
> > Oh, this is not informative at all. I'll get this updated.
> Updated patch attached.
> 

Ok, hostname is properly changed now. I still have some issues:

1) Updated --hostname help doc line in the source code is too long. This
should be split.

2) I miss new --hostname help in ipa-client-install man pages (there can
be the same text as it is in the inline help)

3) When IPA client is uninstalled, I would consider changing the
hostname back to where it was. sysrestore.StateFile could be used for
storing the old hostname value.

Martin