[Freeipa-devel] [PATCH] 067 Silence a compilation warning in ipa_kpasswd

[Jakub Hrozek]

On 07/21/2011 02:53 PM, Martin Kosek wrote:
> On Thu, 2011-07-21 at 14:40 +0200, Jan Cholasta wrote:
>> On 20.7.2011 17:10, Jakub Hrozek wrote:
>>> I was playing with ipa_kpasswd (long story short - I needed it running
>>> on a non-standard port) and I noticed there was a compilation warning -
>>> rtag was set but never checked.
>>>
>>> Also removes one unused #define.
>>>
>>
>> Found just a minor issue: you use spaces for indentation, but the rest 
>> of the file uses tabs.
>>
>> Honza
>>
> 
> To put my 2 cents in - I don't like throwing the same error message in
> more places.
> 
> When it really ends with this message we wouldn't know the exact spot
> with the error. IMO it would make the following investigation simpler if
> we fix this.
> 
> Martin
> 

A new patch is attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-067-02-kpasswd-warnings.patch
Type: text/x-patch
Size: 2235 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110729/6c7e3c9d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110729/6c7e3c9d/attachment.sig>