[Freeipa-devel] [PATCH] 18 Parse netmasks in IP addresses passed to server install

[Jakub Hrozek]

On 06/06/2011 12:28 PM, Jan Cholasta wrote:
> On 2.6.2011 08:23, Jakub Hrozek wrote:
>> On 06/02/2011 08:18 AM, Jakub Hrozek wrote:
>>> On 05/23/2011 08:00 AM, Jan Cholasta wrote:
>>>> On 22.5.2011 18:28, Jakub Hrozek wrote:
>>>>> On 05/20/2011 08:27 PM, Jan Cholasta wrote:
>>>>>> TODO: Clean unreachable code paths off of ipa-server-install (?)
>>>>>
>>>>> In general I agree even though I don't know exactly what code you have
>>>>> in mind -- if the code is dead there's no reason to keep it.
>>>>
>>>> I've noticed that e.g. if the hostname can't be resolved, verify_fqdn
>>>> raises an exception, so some of the checks below the "ip =
>>>> resolve_host(host_name)" line in ipa-server-install are unnecessary,
>>>> but
>>>> I'm not yet sure if I'm not missing something.
>>>>
>>>>>
>>>>>> TODO: Workarounds for netaddr bugs (?)
>>>>>
>>>>> Are these bugs reported upstream? I know you mentioned some in an
>>>>> earlier e-mail, just wondering if they are the same.
>>>>>
>>>>> Long term, it might be better to fix them in netaddr rather than
>>>>> working
>>>>> around them.
>>>>
>>>> Yes, they're the same and are already fixed (according to the netaddr
>>>> bug tracker), but there's no release with the fixes yet (or it's not in
>>>> Fedora). There are not any big issues that I'm aware of, it's just that
>>>> if you specify incorrect netmask with an IPv4 address, the error
>>>> message
>>>> isn't very helpful to the user:
>>>>
>>>> netaddr.IPNetwork('192.168.1.1/33')
>>>> ...
>>>> UnboundLocalError: local variable 'ip' referenced before assignment
>>>>
>>>>>
>>>>> Jakub
>>>>>
>>>>
>>>> Honza
>>>>
>>>
>>
>> I cherry-picked a patch for that issue from upstream and built a fixed
>> python-netaddr:
>> https://admin.fedoraproject.org/updates/python-netaddr-0.7.5-3.fc15
>>
>> Please test and add karma :-)
>>
> 
> Done.
> 

The update went stable today in case you wanted to Require: the fixed
version

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110607/b4b07845/attachment.sig>