[Freeipa-devel] [PATCH] 785 data type of certificates

[Rob Crittenden]

Jan Cholasta wrote:
> On 18.5.2011 17:21, Rob Crittenden wrote:
>> Make data type of certificates more obvious/predictable internally.
>>
>> For the most part certificates will be treated as being in DER format.
>> When we load a certificate we will generally accept it in any format but
>> will convert it to DER before proceeding in normalize_certificate().
>>
>> This also re-arranges a bit of code to pull some certificate-specific
>> functions out of ipalib/plugins/service.py into ipalib/x509.py.
>>
>> This also tries to use variable names to indicate what format the
>> certificate is in at any given point:
>>
>> dercert: DER
>> cert: PEM
>> nsscert: a python-nss Certificate object
>> rawcert: unknown format
>>
>> ticket 32
>>
>> rob
>>
>
> NACK
>
> lint fails with:
>
> ipalib/plugins/host.py:380: [E0602, host_add.pre_callback] Undefined
> variable 'normalize_certificate'
> ipalib/plugins/host.py:381: [E0602, host_add.pre_callback] Undefined
> variable 'verify_cert_subject'
>
> Honza
>

Needed to be re-based with changes to 779.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-785-2-pem.patch
Type: text/x-diff
Size: 31489 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110608/b1caa7cb/attachment.bin>