[Freeipa-devel] [PATCH] 21 Fix directory manager password validation in ipa-nis-manage

[Jan Cholasta]

On 9.6.2011 14:50, Martin Kosek wrote:
> On Wed, 2011-06-08 at 15:21 +0200, Jan Cholasta wrote:
>> https://fedorahosted.org/freeipa/ticket/1283
>> https://fedorahosted.org/freeipa/ticket/1284
>>
>> Honza
>
> Patch works fine, but I'd like to improve code quality a bit. Please
> don't call sys.exit() from get_dirman_password(). It doesn't make really
> sense.
>
> I suggest just returning None in that case and then exiting in the main
> function. Or raising a proper exception and then exiting in the main
> function. The get_dirman_password() function can then be later reused
> easily.

Good point. Fixed.

>
> Martin
>

Honza

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-21.1-ipa-nis-manage-input-validation.patch
Type: text/x-patch
Size: 2620 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110613/69e7319a/attachment.bin>