[Freeipa-devel] [PATCH] 079 DNS installation fails when domain and host domain mismatch

[Martin Kosek]

On Tue, 2011-06-14 at 13:53 -0400, Rob Crittenden wrote:
> Martin Kosek wrote:
> > This patch depends on my patch 078. A special patch for stable branch
> > attached.
> >
> > ---
> >
> > Create DNS domain for IPA server hostname first so that it's forward
> > record can be added. This results in 2 forward DNS zones created
> > when server hostname doesn't equal server domain.
> >
> > https://fedorahosted.org/freeipa/ticket/1194
> 
> This look ok, just a style question.
> 
> by definition fqdn is fully-qualified so is this necessary?
> 
> +        if '.' in self.fqdn:
> +            self.host_domain = '.'.join(fqdn.split(".")[1:])
> +        else:
> +            self.host_domain = self.domain
> 
> The test will always be true, right?
> 
> rob

It should be. Maybe I was overcautious in this place. Attaching updated
patches.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-079-2-dns-host-domain-mismatch.patch
Type: text/x-patch
Size: 1928 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110615/eaafc0ed/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-079-2-ipa-2-0.patch
Type: text/x-patch
Size: 1849 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110615/eaafc0ed/attachment-0001.bin>