[Freeipa-devel] [PATCH] 0237-no-redirect-on-unknown-error

[Adam Young]

On 06/15/2011 09:23 PM, Endi Sukma Dewata wrote:
> On 6/15/2011 6:44 PM, Adam Young wrote:
>> On 06/15/2011 02:37 PM, Adam Young wrote:
>>> Part 2
>>>
>>> https://fedorahosted.org/freeipa/ticket/1281
>
>> Now iterates through a list of known error types.
>
> If the server is down (service ipa stop) it throws an error with name 
> 'NS_ERROR_NOT_AVAILABLE' which is not in the list, so it still does a 
> redirection.
>
> There is another problem too, if the error name matches the list it 
> doesn't call report_error().
>
> Maybe this should be done the other way around. Instead of listing the 
> errors not to redirect, we should list the errors which require 
> redirection, i.e. IPA Error 4001 (entry not found).
>
> This is optional, in ipa.js:337 we could add the IPA error code into 
> the error_thrown object. This way the error can be checked more 
> reliably using error code rather than error name.
>
This version does the whitelist approach
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0237-2-no-redirect-on-unknown-error.patch
Type: text/x-patch
Size: 2164 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110617/8e599911/attachment.bin>