[Freeipa-devel] [PATCH] 079 DNS installation fails when domain and host domain mismatch

[Rob Crittenden]

Rob Crittenden wrote:
> Martin Kosek wrote:
>> On Tue, 2011-06-14 at 13:53 -0400, Rob Crittenden wrote:
>>> Martin Kosek wrote:
>>>> This patch depends on my patch 078. A special patch for stable branch
>>>> attached.
>>>>
>>>> ---
>>>>
>>>> Create DNS domain for IPA server hostname first so that it's forward
>>>> record can be added. This results in 2 forward DNS zones created
>>>> when server hostname doesn't equal server domain.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/1194
>>>
>>> This look ok, just a style question.
>>>
>>> by definition fqdn is fully-qualified so is this necessary?
>>>
>>> + if '.' in self.fqdn:
>>> + self.host_domain = '.'.join(fqdn.split(".")[1:])
>>> + else:
>>> + self.host_domain = self.domain
>>>
>>> The test will always be true, right?
>>>
>>> rob
>>
>> It should be. Maybe I was overcautious in this place. Attaching updated
>> patches.
>>
>> Martin
>
> ack

pushed the respective patches to ipa-2-0 and master

rob