[Freeipa-devel] [v3 patches] Review request

[Simo Sorce]

Hi,
I have a pile of patches in [1], which I'd like some review on.

As explained in a mail to the list some time ago, this is code that will
land in master once we are comfortable in branching it for v3 work.

The first patch is named "Fix build warnings" and all patches on top of
it prefixed with ipa-pwd-extop: or krbinstance: [2] should be safe to be
committed on master even now if someone is willing to test and give
acks.

All the patches prefixed with ipa-kdb: [3] are instead the real v3 work,
and I'd like comments on them.

Keep in mind that this tree keeps being rebased on the current master,
and I still squash in fixes if I find bugs into ipa-kdb patches. But the
work is sort of settled and only minor bugfixing is going to be squashed
in.

I will request additional functional ACKs before merging this work in
master later on, but that will be mostly install/test, I am looking for
a source code level review at this stage.

Thanks,
Simo.

[1]
http://fedorapeople.org/gitweb?p=simo/public_git/freeipa.git;a=log;h=refs/heads/freeipa-v3

[2]
ipa-pwd-extop: Move encoding in common too
ipa-pwd-extop: Move encryption of keys in common
ipa-pwd-extop: Use common krb5 structs from kdb.h
ipa-pwd-extop: re-indent code using old style
ipa-pwd-extop: Use the proper mkvno number in keys
ipa-pwd-extop: do not append mkvno to krbExtraData
ipa-pwd-extop: Remove unused variables and code to... 
krbinstance: use helper function to get realm suffix
ipa-pwd_extop: use endian.h instead of nih function
Fix build warnings

[3]
ipa-kdb: Restrict add/del operations for now  freeipa-v3
ipa-kdb: Get/Store Master Key directly from LDAP
ipa-kdb: add functions to manipulate principals
ipa-kdb: add function to iterate over principals
ipa-kdb: add functions to delete principals
ipa-kdb: add function to free principals
ipa-kdb: functions to get principal
ipa-kdb: add common utility ldap wrapper functions
ipa-kdb: implement get_time function
ipa-kdb: initialize module functions
ipa-kdb: Initial plugin skeleton

-- 
Simo Sorce * Red Hat, Inc * New York