[Freeipa-devel] [PATCH] 23 Add ability to specify DNS reverse zone name by IP network address

Rob Crittenden rcritten at redhat.com
Tue Jun 28 18:08:42 UTC 2011


Jan Cholasta wrote:
> On 21.6.2011 14:15, Jan Cholasta wrote:
>> This patch adds a new option name_from_ip to dnszone commands. Default
>> value of idnsname is created from this option.
>>
>> Honza
>>
>
> Fixed the API version number, added usage example to dns plugin help.
>
> https://fedorahosted.org/freeipa/ticket/1045
>
> Honza

Had quickie code review in IRC this morning. I asked for a comment 
around the while loop, Honza suggested: This is to make chained 
default_from work - idnssoarname default is created from idnsname and 
idnsname default is created from name_from_ip - without this change, 
idnssoarname default value isn't created when only name_from_ip is 
specified.

Would also be nice to have a test case for this new usage.

rob




More information about the Freeipa-devel mailing list