[Freeipa-devel] [PATCH] 0087 Fix winsync agreements setup

[Rob Crittenden]

Simo Sorce wrote:
> On Mon, 28 Feb 2011 11:18:45 -0500
> Rob Crittenden<rcritten at redhat.com>  wrote:
>
>> Simo Sorce wrote:
>>> On Mon, 28 Feb 2011 10:49:29 -0500
>>> Rob Crittenden<rcritten at redhat.com>   wrote:
>>>
>>>> Simo Sorce wrote:
>>>>>
>>>>> Setting up a winsync agreement was broken.
>>>>>
>>>>> This patch fixes the code to allow setting up a winsync agreement
>>>>> that requires access to a non-IPA ldap server.
>>>>>
>>>>> Simo.
>>>>
>>>> This changes the side we initiate the replication startup on. I
>>>> don't know a ton about the internals of 389-ds replication but is
>>>> this necessary? It has been this way for years.
>>>
>>> Sorry, I don't see that.
>>> Where am I doing that ?
>>>
>>> Simo.
>>>
>>
>> This is what I saw:
>>
>>            mod = [(ldap.MOD_ADD, 'nsds5BeginReplicaRefresh', 'start')]
>> -        other_conn.modify_s(dn, mod)
>> +        conn.modify_s(dn, mod)
>>
>> It looks like you renamed the variable from other_conn to to conn so
>> this change is ok.
>
> Oh yes it is just a rename of the variable not an actual change.
>
> Simo.
>

Works great, ack.

rob