[Freeipa-devel] [PATCH] 3 Add ability to specify netmask with IP addresses during installation

[Rob Crittenden]

Dmitri Pal wrote:
> On 03/29/2011 04:15 PM, Rob Crittenden wrote:
>> Jan Cholasta wrote:
>>> Sorry, forgot to attach the patch.
>>>
>>
>> Is this why you have some blind excepts?
>>
>> installutils._IPAddressWithPrefix('192.168.0.1/33')
>> Traceback (most recent call last):
>>    File "<stdin>", line 1, in<module>
>>    File "ipaserver/install/installutils.py", line 167, in __init__
>>      net = netaddr.IPNetwork(addr)
>>    File "/usr/lib/python2.7/site-packages/netaddr/ip/__init__.py", line
>> 919, in __init__
>>      implicit_prefix, flags)
>>    File "/usr/lib/python2.7/site-packages/netaddr/ip/__init__.py", line
>> 782, in parse_ip_network
>>      value = ip._value
>> UnboundLocalError: local variable 'ip' referenced before assignment
>>
>> We should get an upstream bug filed on python-netaddr about this.
>>
>> Shoudl parse_ip_address() raise an exception on bad data rather than
>> returning 0.0.0.0?
>>
>>>>> installutils.parse_ip_address('355.555.3.3')
>> _IPAddressWithPrefix('0.0.0.0')
>>
>> or
>>
>>>>> installutils.parse_ip_address('192.168.0.1/55')
>> _IPAddressWithPrefix('0.0.0.0')
>>
>> Should it disallow net addresses like 192.168.0.0?
>>
>
> No, otherwise I would not be able to test at home.

Sorry, I mean that a .0 is considered a valid IP address to use for the 
server.

rob