[Freeipa-devel] [PATCH] admiyo-0217-define-entities-using-builder-and-more-declarative

[Adam Young]

On 03/28/2011 05:17 PM, Adam Young wrote:
> On 03/28/2011 04:56 PM, Adam Young wrote:
>> To give a little more context:  we are llong to split out the logic 
>> used to define the views of the entities from the reusable portion of 
>> the toolkit.  This patch introduces a builder object which contains 
>> the temporary state of the entity build process.
>>
>> In the course of writing it, I realized a few things:
>>
>> 1.  HBAC and SUDO have two small entities and a single large one.  
>> Thus, it makes sense to group them both into a single file per 
>> entity.  Both hbac.js and sudo.js should shrink more in the future as 
>> the custom code gets better refactored and split into reusable 
>> components and configuration data.
>>
>>
>> 2.  policy.js was a catch all file.  Automount  will grow 
>> significantly this release, and so should have its own file.   DNS is 
>> complicated enough that it deserves its own top level js file.  
>> policy is now reduced to two small entities, both that are very 
>> clearly policy.
>>
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
>
> Self NACK:  jsl and unit test errors need to be fixed first.   Still 
> worth reviewing as is, as fixing that will not change the behavior or 
> structure of the end patch.
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel



Updated with fix for unit tests.   Note that this requires the NACKed 
version of 
freeipa-admiyo-0216-update-metadata-with-label-changes.patch.  The fixes 
in the unit tests here resolve the test breakage due to the metadata 
updates.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110330/aae1affb/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0217-1-define-entities-using-builder-and-more-declarative-s.patch
Type: text/x-patch
Size: 148522 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110330/aae1affb/attachment.bin>