[Freeipa-devel] [PATCH] admiyo-0226-Added-a-container-for-the-facet

[Endi Sukma Dewata]

On 5/2/2011 8:59 PM, Adam Young wrote:
>> This is my attempt at restructuring the DOM and the code:
>> http://edewata.fedorapeople.org/freeipa/install/ui/index.html
>>
>> It's still work in progress, but the main changes are:
>> 1. Navigation is modified to use entity names instead of numerical
>> index.
> Good, ver y good. This will simplify relationships.
>
>> 2. Entity content is moved out of the navigation structure into a
>> separate container.
> Interesting call. I'm pretty sure I am in favor of it, but I'd like to
> hear your rartionale.

Previously the content and the navigation are entangled in the same 
structure which is as you know rather complicated. Separating them 
allows cleaner structure and better reusability, for example suppose 
another project wants to use another type of navigation instead of 
nested tab system.

>> 3. Each facet now has separate container, so we don't need to
>> redraw the page every time we open it.
>> 4. Buttons are moved into facet header. They will appear under the
>> facet tab groups.
>>
>> The code is available in the navigation branch in this repository:
>> git://fedorapeople.org/~edewata/repo.git
>
> I'll wait until you give me the go ahead to review, but the DOM
> structure looks good.

I'll post the patches as usual when they are ready. Thanks.

-- 
Endi S. Dewata