[Freeipa-devel] [PATCH] 048 Remove doc from API.txt

Simo Sorce simo at redhat.com
Fri May 13 12:28:02 UTC 2011


On Fri, 2011-05-13 at 13:29 +0200, Martin Kosek wrote:
> On Thu, 2011-05-12 at 11:27 -0400, Rob Crittenden wrote:
> > Martin Kosek wrote:
> > > On Wed, 2011-05-11 at 17:04 -0400, Rob Crittenden wrote:
> > >> Martin Kosek wrote:
> > >>> Doc parts are not removed from the API completely. This leads to
> > >>> unnecessary updates to API.txt when the option/argument documentation
> > >>> is changed.
> > >>>
> > >>> This patch replaces unreliable doc stripping function with a regular
> > >>> expression. It works for all current doc strings (simple string or
> > >>> GetText). The only limitation is that the RE supports only up to
> > >>> 2 levels of nested parentheses in doc string.
> > >>>
> > >>> https://fedorahosted.org/freeipa/ticket/1057
> > >>
> > >> The approach looks good, can you rebase this?
> > >>
> > >> thanks
> > >>
> > >> rob
> > >
> > > Sure, here it goes.
> > >
> > > Martin
> > 
> > Ack
> 
> Pushed to master, ipa-2-0.
> 
> I had to re-generate API.txt for ipa-2-0 branch, the file was diverged
> between the branches.

Is this a safe change for 2.0.x ?

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list