[Freeipa-devel] [PATCH] 0228-create-entities-on-demand

[Adam Young]

On 05/23/2011 12:38 PM, Adam Young wrote:
> On 05/23/2011 12:06 PM, Endi Sukma Dewata wrote:
>> On 5/23/2011 9:42 AM, Adam Young wrote:
>>> Patch 227 is the automount patch that I still am not ready to submit.
>>> This patch stands alone.
>>
>> A few issues in IPA.get_entity():
>>
>> 1. It executes that.entities.get() twice. The result of the first
>>    invocation can be stored in a variable and reused later. The result
>>    of the factory() invocation can be assigned to the same variable.
>>
>> 2. It executes factory = that.entity_factories[name] twice. The second
>>    one can be removed.
>>
>> Other than that it's ACKed and can be pushed after fixing the above 
>> issues.
>>
> Now with fixed unit tests
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
Better navigation test
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110523/e2434100/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0228-2-create-entities-on-demand.patch
Type: text/x-patch
Size: 4255 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110523/e2434100/attachment.bin>