[Freeipa-devel] [PATCH] 0227-2-automount-UI

[Adam Young]

On 05/24/2011 05:06 PM, Endi Sukma Dewata wrote:
> On 5/24/2011 1:11 PM, Adam Young wrote:
>> Known issues: the back to list links are broken. Add and delete for keys
>> not working due to API issues discussed elsewhere.
>
> Some issues:
>
> 1. The 3rd level tabs (Location, Maps, Keys) can be removed because
>    there's already a breadcrumb which provides the functionality needed.
>    It's not possible to go to a map or key directly without selecting a
>    location, so having a tab for Maps or Keys doesn't quite make sense.
   Tabs are necessary for navigation.  IN the future, we can add nested 
settings and deeply  nested search facets that should allow us to 
navigate on down, but that is a lot more work.


>    Also if you click the Maps or Keys it will go to an empty maps page
>    and clicking the browser's back button doesn't work.

Fixed



>
> 2. The prefix in the page title keeps changing which forces you to
>    re-read the title to make sure you're in the right page.
>    - Automount Location:BOS
>    - Automount Maps:BOS > auto.direct
>    - Automount Keys:BOS > auto.direct > nfsserver:/var/log/dirsrv
>      /var/log/dirsrv
>
>    This can be simplified by removing the entity name:
>    - Automount: BOS
>    - Automount: BOS > auto.direct
>    - Automount: BOS > auto.direct > nfsserver:/var/log/dirsrv
>      /var/log/dirsrv
>
>    This way it will look more like a breadcrumb and be less confusing.
>    The "Automount" itself could be made a link to go to locations.

Agreed, but for now, the only way to make that happen is to modify the 
lable fields for location, keys, and maps.  That will mess things up 
elsewhere.  Alternative is a lot of messy one-off code.

>
> 3. There should be a space after the colon, e.g. "Automount: BOS".

OK

>
> 4. The "Add" button is broken for all entities. It adds the entry but
>    fails to refresh the table. The other Add buttons work fine.

Fixed. Needed to make the same change for add that I made for add and 
add another.

>
> 5. The search filter for maps and keys doesn't work, the results don't
>    change.
Yeah, that was tied in with the "back to list " link.  Still broken

>
> 6. Update operation is broken for all entities because in details.js
>    line 325 the slice() returns an array which is incorrectly inserted
>    into the array of primary keys.

Fixed

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-admiyo-0227-3-automount-UI.patch
Type: text/x-patch
Size: 375861 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110524/f3e2dbbb/attachment.bin>