[Freeipa-devel] [PATCH] 0227-2-automount-UI

[Endi Sukma Dewata]

On 5/25/2011 11:31 AM, Adam Young wrote:

>> 8. The column in the maps search facet doesn't have a title.
> Done. This actually was an indication of a deeper problem, that the
> columns were pointing to the wrong entity for param info.

This is because the nested_search_facet is defined in the containing
entity so it tries to look for the column title in the wrong entity.
The fact that search_facet and nested_search_facet are very similar and 
most changes like this one involve changing that.entity into 
that.nested_entity indicates that they should have been the same class.
The actual value of the entity should be specified as a parameter in
the factory/builder.

Ideally the same search_facet should be used in the nested entity so
most code will work naturally like before except for the primary keys
of the containing entities. However this probably require significant
rewrite. Due to time constraint this is ok for now but keep in mind
that it's subject to further refactoring.

A few more issues:

11. The select_changed() in nested_search_facet is missing some code.
     The Delete button is not enabled/disabled when the selection is
     changed.

12. The automount map has a description field which can be specified
     during add & modify. The UI doesn't have this.

13. The entity's breadcrumb_label could be renamed to 'title' and all
     references to entity's metadata.label that will be used as page
     title can be replaced with this 'title' variable. This can be done
     later.

14. In entity_builder.facet() the code sets the facet's facet_group and
     name. It doesn't seem to be necessary since they have been set in
     the IPA.facet.

15. The changes in ipa_init.json undo recent changes for the Add dialog
     box titles.

16. In widget.js line 1053 there should be a space between
     that.entity_name and that.name.

-- 
Endi S. Dewata