[Freeipa-devel] [PATCH 53/53] ticket 2022 - modify codebase to utilize IPALogManager, obsoletes logging

[Martin Kosek]

Hello Jonh,

the log calls look OK now. I think it will be much easier to use that
way.

Your patch 0052 and this new patch 0001 applies to current master now.
(btw. it would be great if they followed FreeIPA patch policy, i.e.
freeipa-jdennis-52-....patch - it would be easier for me to find and
manipulate these files)

However, pylint discovered 2 problems, I don't think this will fly:

$ ./make-lint 
ipapython/ipa_log_manager.py:176: [E0602,
IPALogManager.configure_from_env] Undefined variable 'parse_log_level'
ipapython/ipa_log_manager.py:190: [E0602,
IPALogManager.configure_from_env] Undefined variable 'parse_log_level'

Martin

On Sat, 2011-11-19 at 12:50 -0500, John Dennis wrote:
> New patch attached which addresses all previous comments.
> 
> * rebased against origin/master
> 
> * new ipa specific module added, ipa_log_manager which
>    has the IPA specific log manager and exports the
>    root_logger symbol.
> 
> * all logging to the root logger is now root_logger.xxx()
>    instead of the more verbose log_mgr.root_logger.xxx()
> 
> * fixed the log level in the file logging, now set to debug.