[Freeipa-devel] [PATCH 53/53] ticket 2022 - modify codebase to utilize IPALogManager, obsoletes logging

[Martin Kosek]

On Tue, 2011-11-22 at 11:23 -0500, John Dennis wrote:
> On 11/21/2011 03:30 AM, Martin Kosek wrote:
> > Hello Jonh,
> >
> > the log calls look OK now. I think it will be much easier to use that
> > way.
> >
> > Your patch 0052 and this new patch 0001 applies to current master now.
> > (btw. it would be great if they followed FreeIPA patch policy, i.e.
> > freeipa-jdennis-52-....patch - it would be easier for me to find and
> > manipulate these files)
> 
> Fixed. This attachment exactly mirrors the original with the patch 
> number information.
> 
> >
> > However, pylint discovered 2 problems, I don't think this will fly:
> >
> > $ ./make-lint
> > ipapython/ipa_log_manager.py:176: [E0602,
> > IPALogManager.configure_from_env] Undefined variable 'parse_log_level'
> > ipapython/ipa_log_manager.py:190: [E0602,
> > IPALogManager.configure_from_env] Undefined variable 'parse_log_level'
> 
> Fixed.
> 
> 

ACK. Pushed to master.

Martin