[Freeipa-devel] [PATCH] 288 Disable enroll button if nothing selected.

Simo Sorce simo at redhat.com
Tue Nov 29 15:14:55 UTC 2011


This patch was also pushed.

On Thu, 2011-09-29 at 13:59 +0200, Petr Vobornik wrote:
> On 09/29/2011 06:50 AM, Endi Sukma Dewata wrote:
> > On 9/28/2011 7:59 PM, Adam Young wrote:
> >> On 09/28/2011 06:50 PM, Endi Sukma Dewata wrote:
> >>> A new IPA.dialog_button class has been added to encapsulate the
> >>> buttons in the dialog box so they can be managed more easily.
> >>>
> >>> The adder dialog has been modified to disable the enroll button if
> >>> there is no entries selected.
> >>>
> >>> Ticket #1856
> >
> > The solution is simple, but it requires refactoring which probably
> > should have been done much earlier. So this patch is like a combination
> > of several patches.
> >
> 
> > As a further enhancement, the IPA.dialog_button class probably can be
> > combined with the IPA.action_button/IPA.button class so we can use icons
> > or enable/disable buttons in a more consistent way. This is one step in
> > that direction.
> I Agree. This would be nice especially in association table widget.
> 
> ACK
> 
> 

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list