[Freeipa-devel] [PATCH] 129 migrate process cannot handle multivalued pkey attribute

[Jan Cholasta]

On 29.9.2011 12:01, Martin Kosek wrote:
> When group/user is migrated, the attribute used for RDN may be
> multivalued. Make sure that we pick the value used in the RDN
> which should be the unique one and not just the first one.
>
> https://fedorahosted.org/freeipa/ticket/1892
>

Every time you do "import *", god kills a kitten. Also, it pollutes the 
module namespace with unnecessary symbols and decreases code readability.

I'm a bit puzzled why do you do this:
+                    try:
+                        pkey = dn[ldap_obj.primary_key.name].lower()
+                    except KeyError:
+                        failed[ldap_obj_name][str(dn)] = 
unicode(_rdn_err_msg)
+                        continue

and not just this:
+                    pkey = ava.value.lower()

Besides that, the issue seems to be fixed.

Honza

-- 
Jan Cholasta