[Freeipa-devel] [PATCH] 143 Fix dnszone-add name_from_ip server validation

Martin Kosek mkosek at redhat.com
Tue Oct 11 13:17:24 UTC 2011


On Tue, 2011-10-11 at 09:10 -0400, Rob Crittenden wrote:
> Martin Kosek wrote:
> > On Tue, 2011-10-11 at 11:03 +0200, Martin Kosek wrote:
> >> Based mainly on Rob's fix proposed in Trac.
> >> ---
> >> Ticket 1627 contained a (temporary hack-ish) fix for dnszone-add
> >> name_from_ip validation which works fine for CLI. However, when
> >> the command is not proceeded via CLI and sent directly to the
> >> RPC server, the server throws Internal Server Error.
> >>
> >> Make sure that the server returns a reasonable error.
> >>
> >> https://fedorahosted.org/freeipa/ticket/1941
> >>
> >
> > We miss a test for name_from_ip parameter. I added 2 unit cases that
> > verify this option works + reports a ValidationError when the IP address
> > is wrong.
> >
> > Martin
> 
> ack
> 

Pushed to master, ipa-2-1.

Martin




More information about the Freeipa-devel mailing list