[Freeipa-devel] [PATCH] 153 Improve hostgroup/netgroup collision checks

[Rob Crittenden]

Martin Kosek wrote:
> When the NGP plugin is enabled, a managed netgroup is created for
> every hostgroup. We already check that netgroup with the same
> name does not exist and provide a meaningful error message.
> However, this error message was also printed when a duplicate
> hostgroup existed.
>
> This patch checks for duplicate hostgroup existence first and
> netgroup on the second place. It also makes sure that when NGP
> plugin is (temporarily) disabled, a colliding netgroup cannot
> be created.
>
> https://fedorahosted.org/freeipa/ticket/1914

NACK, you should use self.obj.handle_duplicate_entry and/or 
self.obj.already_exists_msg for reporting errors. See my patch 898 for 
an example of this.

rob