[Freeipa-devel] [PATCH] 0015 Don't try to remove auxiliary nodes from internal RBT

[Petr Spacek]

On 04/04/2012 10:26 AM, Adam Tkac wrote:
> On Tue, Apr 03, 2012 at 03:06:31PM +0200, Petr Spacek wrote:
>> Hello,
>>
>> this patch optimizes code for removing deleted zones from BIND
>> instance little bit.
>>
>> In some cases there are auxiliary zones (= not really served zones)
>> in internal Red-Black tree. Current code tries to remove these
>> auxiliary zones on each zone_refresh attempt.
>>
>> Everything works fine, because auxiliary zones are detected deeper
>> in zone deletion code.
>> Now plugin prints very confusing message "Zone '%s' has been removed
>> from database." each 'zone_refresh' seconds, again and again. This
>> patch prevents this.
>>
>> I think it's very very confusing. I spent a lot of time while
>> debugging before I realized where is the problem.
>
> The patch is OK, please push it.

I fixed typo in comment and log message. After discussion on IRC I 
adjusted log severity to lower level.

Revised patch is attached.

Pushed to master:
https://fedorahosted.org/bind-dyndb-ldap/changeset/fcaefa5a712d4ffa607d2e99000181e67fe7179a

Petr^2 Spacek

>
> Regards, Adam
>
>> Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bind-dyndb-ldap-pspacek-0015-Don-t-try-to-remove-auxilitary-nodes.patch
Type: text/x-patch
Size: 1205 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120404/6720de9d/attachment.bin>