[Freeipa-devel] [PATCH 71] improve handling of ds instances during uninstall

[John Dennis]

On 04/05/2012 01:26 AM, Alexander Bokovoy wrote:
> On Wed, 04 Apr 2012, John Dennis wrote:
>> +                # Strip off prefix
>> +                instance = basename[len(instance_prefix):]
>> +                # Must be non-empty
>> +                if instance:
>> +                    instances.append(basename[len(instance_prefix):])
> You have already generated basename[len(instance_prefix):], may be it
> could be as simple as
>      instances.append(instance)
> here?
>

Good catch, yup that's what I meant to write, must have been a 
cut-n-paste mistake.

Revised patch attached.

-- 
John Dennis <jdennis at redhat.com>

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jdennis-0071-1-improve-handling-of-ds-instances-during-uninstall.patch
Type: text/x-patch
Size: 6850 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120405/97363bec/attachment.bin>