[Freeipa-devel] [PATCH] 0033 Pass make-test arguments through to Nose + Test coverage

[Rob Crittenden]

Petr Viktorin wrote:
> Currently, our test script forwards a select few command line arguments
> to nosetests.
> This patch removes the filtering, passing all arguments through.
> This allows things like disabling output redirection (--nocapture),
> dropping into a debugger (--pdb, --pdb-failures), coverage reporting
> (--with-cover, once installed), etc.
>
> https://fedorahosted.org/freeipa/ticket/2135
>
> I believe this is a better solution than adding individual options as
> they're needed.
>
>
> ---
>
> A coverage report can be generated by combining data from both the tests
> and the server. I run this:
>
> Setup:
> yum install python-coverage
> echo /.coverage* >> .git/info/exclude
> echo /htmlcov/ >> .git/info/exclude
>
> Terminal 1:
> coverage erase
> coverage run -p --source . lite-server.py
>
> Terminal 2:
> kinit
> ./make-test --with-coverage --cover-inclusive
>
> Terminal 1 again:
> ^C
> coverage combine
> coverage html --omit=/usr/lib/*
>
> Then view ./htmlcov/index.html in a browser.

This looks very good to me. I'll open a ticket to go through the 
coverage to find weaknesses.

John, this replaces your existing patch, does this still fit the bill?

rob