[Freeipa-devel] [PATCH] 20 Fix empty external member processing

Martin Kosek mkosek at redhat.com
Tue Apr 17 14:29:20 UTC 2012


On Tue, 2012-04-03 at 15:22 +0200, Ondrej Hamada wrote:
> On 04/03/2012 12:22 PM, Ondrej Hamada wrote: 
> > https://fedorahosted.org/freeipa/ticket/2447 
> > 
> > Validation of external member was failing for empty strings because
> > of 
> > wrong condition. 
> > 
> > 
> > 
> > _______________________________________________
> > Freeipa-devel mailing list
> > Freeipa-devel at redhat.com
> > https://www.redhat.com/mailman/listinfo/freeipa-devel
> 
> Used clearer solution. Thanks to Rob for advice.

ACK. Pushed to master, ipa-2-2.

I just replaced:
+    if options.get(membertype,False):
with
+    if options.get(membertype):
as it was redundant.

Validation of externalHost attribute passed via --setattr or --addattr
shall be solved in ticket #2649.

Martin




More information about the Freeipa-devel mailing list