[Freeipa-devel] [PATCH] 122 Added permission field to delegation

[Endi Sukma Dewata]

On 4/18/2012 10:02 AM, Rob Crittenden wrote:
> Petr Vobornik wrote:
>> Permission field is missing in delegation so it can't be set/modified.
>>
>> It was added to delegation details facet and adder dialog.
>>
>> The field is using checkboxes instead of multivalued textbox because it
>> can have only two effective values: 'read' and 'write'.
>>
>> https://fedorahosted.org/freeipa/ticket/2635
>>
>
> Works great. ACK, pushed to master and ipa-2-2
>
> rob

Some possible enhancements:

During delegation add the permission is optional but it defaults to 
"write". The UI doesn't say anything about the default value, it's only 
noted in the delegation-add help doc. During modify the help doc also 
says the default is "write" but permission is actually required (can't 
set to empty), so no need for a default value.

1. Would it be better in the UI during add we make the permission 
required but the "write" checkbox is checked by default? This way it's 
more consistent with the edit page and it also shows the default value.

2. Should we remove the "Default is write" from delegation-mod help doc?

-- 
Endi S. Dewata