[Freeipa-devel] [PATCH] 255 Improve error message in zonemgr validator

[Martin Kosek]

On Mon, 2012-04-30 at 14:02 +0200, Martin Kosek wrote:
> This patch consolidates zonemgr function to move the most of the
> checks to common functions in order to provide consistent output.
> The error messages produced by the validator should now be more
> helpful when identifying the source of error.
> 
> https://fedorahosted.org/freeipa/ticket/1966

Rob found a corner case with "foo..bar" where the error message was not
as helpful as it could be. Now, the empty parts are handled better:

# ipa dnszone-mod example.com --admin-email=.foo
ipa: ERROR: invalid 'admin_email': missing mail account
# ipa dnszone-mod example.com --admin-email=foo.
ipa: ERROR: invalid 'admin_email': missing address domain
# ipa dnszone-mod example.com --admin-email=foo..bar
ipa: ERROR: invalid 'admin_email': empty DNS label

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-255-2-improve-error-message-in-zonemgr-validator.patch
Type: text/x-patch
Size: 4086 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120430/f3064e45/attachment.bin>