[Freeipa-devel] [PATCHES] 177-184 Rebase of jquery and jquery-ui libs

Wed Aug 1 13:43:15 UTC 2012

On 07/31/2012 09:34 PM, Endi Sukma Dewata wrote:
> On 7/27/2012 11:59 AM, Petr Vobornik wrote:
>> This effort was driven by ticket
>> https://fedorahosted.org/freeipa/ticket/2817 which needed update of
>> jqury-ui library. When I was at it I also updated core jquery lib. All
>> patches are associated with ticket #2817 which might be bad. Should I
>> split it to more tickets?
>>
>> This effort makes Web UI look consistent in Firefox, Chrome, Opera and
>> IE. I didn't try Safari. Also it fixes some visual issues (mostly in IE
>> and Opera) and makes buttons prettier.
>>
>> Patches 177,178 are rebases of jquery and jquery-ui libraries. Upgrade
>> introduced two new functional bugs and 2 test bugs which are fixed by
>> patches 179, 182 and 183. Update of jquery-ui.css made some parts of
>> ipa.css redundant so the redundancy is removed in patch 180. Patch 180
>> also removes some styles which make buttons in association dialog look
>> bad. Patch 181 utilizes jquery.button and so makes buttons in
>> association dialogs consistent with the rest of the UI. Patch 184 is
>> just tiny refactoring.
>>
>>
>> Patch notes:
>> [PATCH] 177 Update to jquery.1.7.2.min
>>
>> jquery library wasn't updated for a long time.
>>
>>
>> [PATCH] 178 Update to jquery-ui-1.8.21.custom
>>
>> jquery-ui was regenerated to up to date version.
>>
>> Border radius and IPA custom colors were added to theme so we don't have
>> to override them in ipa.css.
>>
>> [PATCH] 179 Fix for incorrect event handler definition
>>
>> Clicks events should be better defined by jquery calls (usually
>> addEventListener) not as elements attributes. Definition as element
>> attribute causes problems after upgrade to jquery 1.7.2. Two occurances
>> were removed.
>>
>> [PATCH] 180 Removal of unnecessary overrides of jquery-ui styles
>>
>> ipa.css had to be updated to work with updated jquery-ui. This patch
>> removes several duplicate styles.
>>
>> Following issues were fixed:
>>   * dialogs titles in IE and Opera were black instead of green
>>   * no black line in first navigation level in IE and Opera
>>   * all browsers (FF, IE, Chrome, Opera) have the same style for buttons
>> and headers
>>   * dialogs has borders again (should we remove its shadow?)
>>
>> Known issues:
>>   * selected tab-1 in Chrome and Opera doesn't overlaps background line
>> as in IE and FF. Not sure how to fix without breaking (there are border
>> overlaps) the latter ones. I think it looks good enough.
>>   * some buttons are missing padding. Will be fixed in next patch.
>>
>> [PATCH] 181 Unified buttons
>>
>> Buttons in association dialog and action list have different style and
>> behavior than buttons in dialogs. This patch unifies it by using
>> jquery.button widget.
>>
>> [PATCH] 182 Web UI tests fix
>>
>> ACI tests were crashing because of misconfigured facet.
>> Entity link test were crashing because of incorrect jquery selector.
>>
>> [PATCH] 183 Fixed incorrect use of jQuery.attr for setting disabled
>>   attribute
>>
>> Occurance: select_widget
>>
>> Update to latest version of jQuery uncovered this issue.
>>
>> [PATCH] 184 Replace use of attr with prop for booleans
>>
>> Recommened way of setting boolean HTML attributes is by $.prop(boolean)
>> method not $.attr(boolean) because it sets DOM object property not an
>> attribute. Latter works because of jquery's backward compatibility. This
>> patch makes things clearer.
>>
>> Some info about prop and attr: http://stackoverflow.com/a/5876747
>
> The build fails, it looks like the Makefile in install/ui/images needs
> to be updated:
>
> make[5]: Entering directory
> `/home/edewata/IPA/freeipa/rpmbuild/BUILD/freeipa-3.0.0GIT97e51ff/install/ui/images'
>
> make[5]: *** No rule to make target `ui-bg_glass_40_111111_1x400.png',
> needed by `all-am'.  Stop.
> make[5]: Leaving directory
> `/home/edewata/IPA/freeipa/rpmbuild/BUILD/freeipa-3.0.0GIT97e51ff/install/ui/images'
>
> make[4]: *** [all-recursive] Error 1
> make[4]: Leaving directory
> `/home/edewata/IPA/freeipa/rpmbuild/BUILD/freeipa-3.0.0GIT97e51ff/install/ui'
>
> make[3]: *** [all-recursive] Error 1
> make[3]: Leaving directory
> `/home/edewata/IPA/freeipa/rpmbuild/BUILD/freeipa-3.0.0GIT97e51ff/install'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory
> `/home/edewata/IPA/freeipa/rpmbuild/BUILD/freeipa-3.0.0GIT97e51ff/install'
> make[1]: *** [all] Error 1
> make[1]: Leaving directory
> `/home/edewata/IPA/freeipa/rpmbuild/BUILD/freeipa-3.0.0GIT97e51ff'
> error: Bad exit status from /var/tmp/rpm-tmp.thVPHP (%build)
>
>
> RPM build errors:
>      Bad exit status from /var/tmp/rpm-tmp.thVPHP (%build)
> make: *** [rpms] Error 1
>
Silly mistake. I should test builds more often when playing with 
files... Updated patch 178 attached. Build and install should work.

-- 
Petr Vobornik


-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0178-1-Update-to-jquery-ui-1.8.21.custom.patch
Type: text/x-patch
Size: 457554 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120801/12c66051/attachment.bin>