[Freeipa-devel] [PATCH] 0004-2 Corrects help description of selinuxusermap.

[Tomas Babej]

Suggestion incorporated.

Tomas

----- Original Message -----
From: "Martin Kosek" <mkosek at redhat.com>
To: "Tomas Babej" <tbabej at redhat.com>
Cc: freeipa-devel at redhat.com
Sent: Friday, August 10, 2012 3:43:06 PM
Subject: Re: [Freeipa-devel] [PATCH] 0004 Corrects help description of selinuxusermap.

On 08/10/2012 01:09 PM, Tomas Babej wrote:
> I forgot the patch once again.
> 
> ----- Original Message -----
> From: "Tomas Babej" <tbabej at redhat.com>
> To: freeipa-devel at redhat.com
> Sent: Friday, August 10, 2012 12:44:41 PM
> Subject: [Freeipa-devel] [PATCH] 0004 Corrects help description of	selinuxusermap.
> 
> Hi,
> 
> I checked the rest of the description as well, seems alright.
> 
> https://fedorahosted.org/freeipa/ticket/2959
> 
> Tomas
> 

That's a good start. I would also change the following descriptions a bit:

 Disable a named rule:
   ipa selinuxusermap-disable test1

 Enable a named rule:
   ipa selinuxusermap-enable test1

...

 Remove a named rule:
   ipa selinuxusermap-del john_unconfined

I don't know why all rule are specified as "named". I think that simple

Disable a rule:
Enable a rule:
Remove a rule:

would be enough and less confusing.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-tbabej-0004-2-Corrects-help-description-of-selinuxusermap.patch
Type: text/x-patch
Size: 1763 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120810/247496d7/attachment.bin>