[Freeipa-devel] [PATCH] 0004-3 Corrects help description of selinuxusermap.

[Martin Kosek]

On 08/14/2012 03:17 PM, Tomas Babej wrote:
> ----- Original Message -----
> From: "Martin Kosek" <mkosek at redhat.com>
> To: "Tomas Babej" <tbabej at redhat.com>
> Cc: freeipa-devel at redhat.com
> Sent: Tuesday, August 14, 2012 8:41:44 AM
> Subject: Re: [Freeipa-devel] [PATCH] 0004-2 Corrects help description of selinuxusermap.
> 
> Looking at the changes, I think there is still one line that does not make much
> sense:
> 
> - Display the properties of a named HBAC rule:
> + Display the properties of a HBAC rule:
>     ipa selinuxusermap-show test1
> 
> This should rather really show a HBAC rule used in previous command
> (hbacrule-show command) or not mention HBAC rule at all and show test2 rule
> added in previous step.
> 
> Martin
> 
> On 08/10/2012 04:44 PM, Tomas Babej wrote:
>> Suggestion incorporated.
>>
>> Tomas
>>
>> ----- Original Message -----
>> From: "Martin Kosek" <mkosek at redhat.com>
>> To: "Tomas Babej" <tbabej at redhat.com>
>> Cc: freeipa-devel at redhat.com
>> Sent: Friday, August 10, 2012 3:43:06 PM
>> Subject: Re: [Freeipa-devel] [PATCH] 0004 Corrects help description of selinuxusermap.
>>
>> On 08/10/2012 01:09 PM, Tomas Babej wrote:
>>> I forgot the patch once again.
>>>
>>> ----- Original Message -----
>>> From: "Tomas Babej" <tbabej at redhat.com>
>>> To: freeipa-devel at redhat.com
>>> Sent: Friday, August 10, 2012 12:44:41 PM
>>> Subject: [Freeipa-devel] [PATCH] 0004 Corrects help description of	selinuxusermap.
>>>
>>> Hi,
>>>
>>> I checked the rest of the description as well, seems alright.
>>>
>>> https://fedorahosted.org/freeipa/ticket/2959
>>>
>>> Tomas
>>>
>>
>> That's a good start. I would also change the following descriptions a bit:
>>
>>  Disable a named rule:
>>    ipa selinuxusermap-disable test1
>>
>>  Enable a named rule:
>>    ipa selinuxusermap-enable test1
>>
>> ...
>>
>>  Remove a named rule:
>>    ipa selinuxusermap-del john_unconfined
>>
>> I don't know why all rule are specified as "named". I think that simple
>>
>> Disable a rule:
>> Enable a rule:
>> Remove a rule:
>>
> 
> 
>> would be enough and less confusing.
>>
>> Martin
>>
>>
> 
> I chose the second variant. As these are examples for ipa selinuxusermap,
> it seemed more appropriate.
> 
> Tomas
> 

ACK. Pushed to master.

Martin