[Freeipa-devel] [PATCH] 0005-3 Improves exception handling in ipa-replica-prepare.

[Martin Kosek]

On 08/14/2012 03:22 PM, Tomas Babej wrote:
> ----- Original Message -----
> From: "Martin Kosek" <mkosek at redhat.com>
> To: "Tomas Babej" <tbabej at redhat.com>
> Cc: freeipa-devel at redhat.com
> Sent: Tuesday, August 14, 2012 8:55:19 AM
> Subject: Re: [Freeipa-devel] [PATCH] 0005-2 Improves exception handling in ipa-replica-prepare.
> 
>> On 08/10/2012 04:32 PM, Tomas Babej wrote:
>>> Man page edited.
>>>
>>> ----- Original Message -----
>>> From: "Martin Kosek" <mkosek at redhat.com>
>>> To: "Tomas Babej" <tbabej at redhat.com>
>>> Cc: freeipa-devel at redhat.com
>>> Sent: Friday, August 10, 2012 3:49:45 PM
>>> Subject: Re: [Freeipa-devel] [PATCH] 0005 Improves exception handling in ipa-replica-prepare.
>>>
>>> On 08/10/2012 03:07 PM, Tomas Babej wrote:
>>>> Hi,
>>>>
>>>> A backtrace is no longer displayed when trying to prepare a replica
>>>> file with the local LDAP server down. Also adds --debug option and
>>>> no longer displays info log messages without it.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/2939
>>>>
>>>> Tomas
>>>>
>>>
>>> Looks OK. We just also need to update the ipa-replica-prepare man page, when
>>> changing its options.
>>>
>>> Martin
>>>
>>
>> I tested the patch and the ipa-replica-prepare part works fine, except for the
>> man page which is not formatted correctly.
>>
>> Please, always test your changes in man pages, it is easy to do a formatting
>> error here.
>>
>> Martin
> 
> I corrected the hidden glitch in the man page.
> 
> Tomas
> 

ACK. Pushed to master.

Martin