[Freeipa-devel] [PATCH] trust CLI: add ID range for new trusted domain

[Alexander Bokovoy]

On Tue, 14 Aug 2012, Sumit Bose wrote:
>Hi,
>
>currently only a default ID range was used for users from trusted
>domains. With these two patches an individual range is created during
>ipa trust-add and it will be used by the extdom plugin to calculate the
>Poisx UID for the users from the trusted domain.
>
>'ipa trust-add' is getting two new options, --base-id and --range-size
>to specify the first Posix ID of the range and the size of the range
>respectively. If --range-size is not given the default will be 200000
>and if --base-id is not given it will be calculated with the help of a
>hash of the domain SID. To be compatible with the AD provider of SSSD
>murmurhash3 is used here. The python binding for the hash will be
>provided by SSSD, the patch is currently under review. But since it is
>not required to have murmurhash3, an error message will be send if it is
>not installed on the server, I think this patch can be pushed
>independently of the SSSD patch.

ACK with one fix (attached): ignore missing murmurhash python module and
samba4/server code. This will be required if building client-side
only since ipalib/plugins/trust.py will be included into the client
tarball.


-- 
/ Alexander Bokovoy
-------------- next part --------------
>From 86a336823c8de7ccba4edfbe7bd5ccf88f0f3d7c Mon Sep 17 00:00:00 2001
From: Alexander Bokovoy <abokovoy at redhat.com>
Date: Thu, 16 Aug 2012 19:57:30 +0300
Subject: [PATCH 4/5] Ignore lint errors if pysssd_murmur and samba4 support
 not installed when building client code.

Since ipalib.plugins.trust has both client-side and server-side code,
this is the only way to properly handle linting errors.
---
 ipalib/plugins/trust.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ipalib/plugins/trust.py b/ipalib/plugins/trust.py
index 1064a06783892f27c56f0310046216881db5b42a..f19a0a874057860d0ae32f1cc2336bdc3accf6e5 100644
--- a/ipalib/plugins/trust.py
+++ b/ipalib/plugins/trust.py
@@ -25,14 +25,14 @@ from ipalib import errors
 from ipapython import ipautil
 from ipalib import util
 try:
-    import pysss_murmur
+    import pysss_murmur #pylint: disable=F0401
     _murmur_installed = True
 except Exception, e:
     _murmur_installed = False
 
 if api.env.in_server and api.env.context in ['lite', 'server']:
     try:
-        import ipaserver.dcerpc
+        import ipaserver.dcerpc #pylint: disable=F0401
         _bindings_installed = True
     except Exception, e:
         _bindings_installed = False
-- 
1.7.11.4