[Freeipa-devel] [PATCH] 197 Fixed search in HBAC test

[Endi Sukma Dewata]

On 8/21/2012 9:03 AM, Petr Vobornik wrote:
> Search in HBAC test wasn't working because expired flag wasn't set.
>
> https://fedorahosted.org/freeipa/ticket/2931
>
> Notes: HBAC facets don't have refresh button. They can be refreshed by
> changing filter and searching. If one search with same filter, it sets
> expired flag but it doesn't refresh (search) because page state isn't
> changed. It refreshes when one go to different facet and returns back.
> Is this behavior acceptable? Or should we
> a) don't set expired flag when searching with unchanged filter
> b) force refresh when searching with unchanged filter
> c) add refresh button along with a)
> I prefer leave it as is or b)

Hmm.. the behavior is consistent with the rest of the UI, but I think 
when the user hits Enter or clicks the Search icon in the filter box 
he'd expect the UI to run a new search and return the latest result even 
if it's the same filter. I agree with option (b). A Refresh button can 
be added too, but it's optional.

So this patch is ACKed, but feel free to make a future improvement. 
Maybe instead of having an 'expired flag' we could store an 'expiration 
date'. If the user returns to the page before it expires, the UI can 
show the old data. Otherwise the UI will rerun the search.

-- 
Endi S. Dewata