[Freeipa-devel] [PATCH] 1074 limit service list

[Simo Sorce]

On Tue, 2012-12-04 at 21:32 -0500, Rob Crittenden wrote:
> Simo Sorce wrote:
> > On Tue, 2012-12-04 at 15:56 -0500, Rob Crittenden wrote:
> >> Simo Sorce wrote:
> >>> On Tue, 2012-12-04 at 15:14 -0500, Rob Crittenden wrote:
> >>>> Simo Sorce wrote:
> >>>>> On Tue, 2012-12-04 at 14:03 -0500, Rob Crittenden wrote:
> >>>>>> Only touch the service list in the server installer and ipactl.
> >>>>>
> >>>>> Nack, comments inline.
> >>>>>
> >>> [..]
> >>>>> This break the fallback we have in ipa_stop()
> >>>>> We expect an exception or a non empty list there.
> >>>>
> >>>> Ok, I can move the handling so ipactl ignores the exception.
> >>>
> >>> Is the problem that we are printing an error to stdout/stderr ?
> >>> Or do you actually want to change behavior somehow ?
> >>
> >> We need to change the behavior.
> >>
> >> If you run: ipactl stop
> >>
> >> then: ipactl status
> >>
> >> you get a backtrace because the service list doesn't exist.
> >
> > Ok, what about defining our own exception and then simply pass on it
> > except for the stop() case that treats it differently ?
> 
> I think checking for file existence is probably going to hit the 
> majority of the cases. Using a separate exception is probably overkill.


ACK

Simo.


-- 
Simo Sorce * Red Hat, Inc * New York