[Freeipa-devel] [PATCH] 339 Change network configuration file

[Martin Kosek]

On 12/05/2012 11:17 AM, Alexander Bokovoy wrote:
> On Wed, 05 Dec 2012, Martin Kosek wrote:
>> Fedora+systemd changed deprecated /etc/sysconfig/network which was
>> used by IPA to store static hostname for the IPA machine. See
>> https://bugzilla.redhat.com/show_bug.cgi?id=881785 for details.
>>
>> Change Fedora platform files to store the hostname to /etc/hostname
>> instead.
>>
>> https://fedorahosted.org/freeipa/ticket/3279
> NACK.
> 
> My main objection is that it is Fedora 18 feature but you are
> incorporating it into fedora16 platform code.
> 
> Perhaps we need to split out to fedora18 platform with this change
> and make sure we build with 'fedora18' platform on Fedora 18?
> 
> 'fedora18' platform would inherit from fedora16 code and only override
> these two methods.
> 

That makes sense. I did that + moved restore_hostname function from platform
files because it does not differ between platform versions.

Updated patch attached.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-339-2-change-network-configuration-file.patch
Type: text/x-patch
Size: 13339 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20121205/e78fb1e8/attachment.bin>