[Freeipa-devel] [PATCH] 0006 Raise ACI error when CSR has no subject hostname

[Lynn Root]

> The following raises ACIError because of failed authorization check, I think
> its ok.
>
> RequirementError is only thrown when a command option that is required is not
> passed by the user. I am not fond of expanding its use to the validation of
> user content, like CSR file.
>
> NotFound error is used when an _entry_ is not found - so not an ideal candidate
> either for this case.
>
> IMHO, ValidationError is fine for this situation - but maybe somebody else may
> have other opinion...
>
> Martin
I assume no one is up in arms about electing to go for ValidationError :)

New patch attached.  Thanks for your help, Martin!

-- 
Lynn Root

@roguelynn
Associate Software Engineer
Red Hat, Inc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-lroot-0006-02-Raise-ValidationError-when-CSR-does-not-have-a-subje.patch
Type: text/x-patch
Size: 1126 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20121211/f89ec7e9/attachment.bin>