[Freeipa-devel] [PATCH 101] Fix error handling in ldap_entry_create()

[Petr Spacek]

On 12/13/2012 03:17 PM, Adam Tkac wrote:
> On Thu, Nov 22, 2012 at 09:56:12AM +0100, Petr Spacek wrote:
>> >Hello,
>> >
>> >apparently I was very tired yesterday ... Cleaned version of the
>> >patch is attached.
>> >
>> >Petr^2  Spacek
>> >
>> >On 11/21/2012 05:04 PM, Petr Spacek wrote:
>>> > >Hello,
>>> > >
>>> > >fixed fix is attached. Clang found bug in the fix but I didn't notice that
>>> > >because of other warnings ...
>>> > >
>>> > >On 11/21/2012 04:04 PM, Petr Spacek wrote:
>>>> > >>Hello,
>>>> > >>
>>>> > >>I noticed this problem during investigation of dead code found by Clang.
>>>> > >>
>>>> > >>     Fix error handling in ldap_entry_create().
>>>> > >>
>>>> > >>     Jump to cleanup section after first memory allocation created memory leak
>>>> > >>     which crashed BIND on reload.
>>>> > >>
>>>> > >>     Missing return value check after ldap_get_dn() call can lead to crash.
> Ack
>
Pushed to master and v2: 2727a4b575869c8769c886bf8e2a780bc9f56c6d

-- 
Petr^2 Spacek