[Freeipa-devel] [PATCH 92] Flush whole zone from cache during zone renaming/removal.

Petr Spacek pspacek at redhat.com
Mon Dec 17 09:52:15 UTC 2012


On 12/13/2012 05:07 PM, Adam Tkac wrote:
> On Wed, Dec 05, 2012 at 01:25:56PM +0100, Petr Spacek wrote:
>> >On 12/04/2012 02:36 PM, Adam Tkac wrote:
>>> > >On Thu, Nov 15, 2012 at 07:06:37PM +0100, Petr Spacek wrote:
>>>>> > >>>Hello,
>>>>> > >>>
>>>>> > >>>attached patch is preliminary implementation of selective zone flush.
>>>>> > >>>
>>>>> > >>>
>>>>> > >>>Implementation is not so straight-forward as I want to see. Before
>>>>> > >>>discussing the patch itself - can we consider per-zone caches? In
>>>>> > >>>that case, we can simply deallocate whole per-zone RBT and we are
>>>>> > >>>done.
>>>>> > >>>
>>>>> > >>>Pros:
>>>>> > >>>* Potentially better concurrency, simpler code, much less corner cases.
>>>>> > >>>
>>>>> > >>>Cons:
>>>>> > >>>* We have to look into Zone register before searching the cache.
>>>>> > >>>* It can limit concurrency ... with many extra small zones? I'm not sure.
>>> > >Hi Peter,
>>> > >
>>> > >In my opinion per-zone caches are better. Look into zone register isn't
>>> > >costly operation.
>> >Second version of the patch with per-zone caches is attached. I cut
>> >all debugging code so this version could be considered as final.
> Ack

Re-based on top of patch 106 and pushed to master and v2: 
b367091b867bc8541bb842b06a41fe70f1f3a001

-- 
Petr^2 Spacek




More information about the Freeipa-devel mailing list