[Freeipa-devel] [PATCH] 0003 Honor the default home directory in user_add

Petr Viktorin pviktori at redhat.com
Tue Feb 7 12:52:20 UTC 2012


Honor the default home directory base when creating a new user. Test 
included. I also cleaned up the way home directory was created.

This patch removes the default from the --homedirectory option, letting 
the server fill it in pre_callback. If I'm reading this correctly, 
default_from and create_default run on the client-side, so they can't 
get to the config without round-tripping to the server.

https://fedorahosted.org/freeipa/ticket/2332

Also, I've cleaned up the home directory generation to use 
posixpath.join instead of '%s/%s' and ad-hoc cleanup. This should be 
more robust. (It will also behave differently if the username starts 
with '/' or maybe similar cases of the user asking for trouble.)

A question: Do we want to use posixpath here, or os.path? Put another 
way, should the home directories separated by '\' if the server runs on 
Windows?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0003-Honor-the-default-home-directory-in-user_add.patch
Type: text/x-patch
Size: 5508 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20120207/1c5d3ade/attachment.bin>


More information about the Freeipa-devel mailing list