[Freeipa-devel] [PATCH] [ipa-2-1] 183 Make sure that install tools log

Alexander Bokovoy abokovoy at redhat.com
Mon Jan 2 16:35:24 UTC 2012


On Mon, 02 Jan 2012, Martin Kosek wrote:
> This is a ipa-2-1 branch fix only. master branch use better and more
> sophisticated approach to fix logging (ticket 2022).
> 
> ----
> When any log message is emitted before IPA install tools logging is
> configured, it may break and leave install tools log empty. This
> happens for example when
> 
> ipa-server-install --ip-address=$IP_ADDRESS
> 
> is run.
> 
> This patch makes sure that logging is right in these cases.
> 
> https://fedorahosted.org/freeipa/ticket/2214
This is a good start. However, we'll still get messages from 
--ip-address processing lost.

What about adding a Handler class to buffer LogRecords?

Set it in the root logger as the very first action in those three 
tools (ipa-dns-install, ipa-replica-prepare, ipa-server-install) that accept 
--ip-address option.

When standard_logging_setup() is called, it would check for existing 
handlers and first pull in the records, then remove the handler, 
call basicSetup() and re-issue the LogRecords again?

This way we'll get all the records recovered and will get around 
IPACheckedAddress limitations.

-- 
/ Alexander Bokovoy




More information about the Freeipa-devel mailing list