[Freeipa-devel] [PATCH] 062-065 Ticket 1466 Validate AAAA records as valid IPv6 prior to sending to server

[Endi Sukma Dewata]

On 1/3/2012 3:06 AM, Petr Vobornik wrote:
> 1) 62-Added-support-of-custom-field-validators
> 2) 63-Added-validation-logic-to-multivalued-text-field - depends on 1
> 3) 64-Added-client-side-validation-of-A-and-AAAA-DNS-recor - depends on 1
> 4) 65-Fixed-IPv6-validation-special-case-single-colon - minor fix

ACK and pushed to master. There are some minor issues but they can be 
fixed later since they don't cause regression:

1. The IPv4 validator can take quads or integer, but it looks like 
according to RFC 1035 section 3.4.1 (http://tools.ietf.org/html/rfc1035) 
the A record should only take quads:

   A records cause no additional section processing.  The RDATA section
   of an A line in a master file is an Internet address expressed as four
   decimal numbers separated by dots without any imbedded spaces (e.g.,
   "10.2.0.52" or "192.0.5.6")

2. The DNS record adder dialog doesn't validate the A/AAAA records. We 
might want to define some hidden fields, one field for each record type, 
then the field will only appear if you select the type from the 
drop-down list. This way each field can have its own validators. This 
solution is similar to permission target widget and will be the basis 
for ticket #2208.

3. The host adder dialog doesn't validate the IP address.

4. The widget_value_changed() in IPA.multivalued_field is not needed 
because it's identical to the one in IPA.field.

5. Existing problem, in the DNS Resource Records page the delete 
operation doesn't work. I think this will be addressed in #2094.

6. Existing problem, in the extract_child_value() in 
IPA.multivalued_text_widget if the value is an empty array the function 
will return the array itself instead of empty string.

7. Existing problem, in net.js:330 the error message should be for 
leading instead of trailing zeros.

-- 
Endi S. Dewata